Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Philippe Mathieu-Daudé
On 2/11/18 18:42, Peter Maydell wrote: On 2 November 2018 at 17:38, Philippe Mathieu-Daudé wrote: Hi Peter, On 2/11/18 12:52, Peter Maydell wrote: We can remove entirely the note in rebuild-expected-aml.sh about copying any new data files, because now they will be in the source directory, not

Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Peter Maydell
On 2 November 2018 at 17:38, Philippe Mathieu-Daudé wrote: > Hi Peter, > > On 2/11/18 12:52, Peter Maydell wrote: >> We can remove entirely the note in rebuild-expected-aml.sh >> about copying any new data files, because now they will >> be in the source directory, not the build directory, and >>

Re: [Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Philippe Mathieu-Daudé
Hi Peter, On 2/11/18 12:52, Peter Maydell wrote: Currently tests/acpi-test-data contains data files used by the bios-tables-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, because if a new data file

[Qemu-devel] [PATCH v2 for-3.1 1/4] tests: Move tests/acpi-test-data/ to tests/data/acpi/

2018-11-02 Thread Peter Maydell
Currently tests/acpi-test-data contains data files used by the bios-tables-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, because if a new data file is added, nothing causes configure to be rerun, and