Re: [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value

2016-01-11 Thread Paolo Bonzini
On 11/01/2016 08:23, P J P wrote: > Hello, > > +-- On Wed, 6 Jan 2016, P J P wrote --+ > | When processing firmware configurations, an OOB r/w access occurs > | if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0x). > | Add a check to validate 's->cur_entry' to avoid such access. > |

Re: [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value

2016-01-11 Thread P J P
+-- On Mon, 11 Jan 2016, Paolo Bonzini wrote --+ | > +-- On Wed, 6 Jan 2016, P J P wrote --+ | > -> https://patchwork.ozlabs.org/patch/563706/ | > Ping...! Does it look okay? (just checking) | | Yes, it looks good. Okay, thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69

Re: [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value

2016-01-10 Thread P J P
Hello, +-- On Wed, 6 Jan 2016, P J P wrote --+ | When processing firmware configurations, an OOB r/w access occurs | if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0x). | Add a check to validate 's->cur_entry' to avoid such access. | | Reported-by: Donghai Zdh

[Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value

2016-01-05 Thread P J P
From: Prasad J Pandit When processing firmware configurations, an OOB r/w access occurs if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0x). Add a check to validate 's->cur_entry' to avoid such access. Reported-by: Donghai Zdh