Re: [Qemu-devel] [PATCH v22 04/25] improve assertion in qemu_opt_get functions

2014-03-12 Thread Chunyan Liu
2014-03-11 5:44 GMT+08:00 Eric Blake ebl...@redhat.com: On 03/10/2014 01:31 AM, Chunyan Liu wrote: In qemu_opt_set functions, if desc doen't exist but opts_accepts_any is true, it s/doen't/doesn't/ I mentioned the same problem against v20. It is very depressing when review comments are

[Qemu-devel] [PATCH v22 04/25] improve assertion in qemu_opt_get functions

2014-03-10 Thread Chunyan Liu
In qemu_opt_set functions, if desc doen't exist but opts_accepts_any is true, it won't report error, but can still alloc an opt for the option and save it. However, after that, when doing qemu_opt_get, this option could be found in opts but opt-desc is NULL. This is correct, should not be treated

Re: [Qemu-devel] [PATCH v22 04/25] improve assertion in qemu_opt_get functions

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: In qemu_opt_set functions, if desc doen't exist but opts_accepts_any is true, it s/doen't/doesn't/ I mentioned the same problem against v20. It is very depressing when review comments are not addressed. won't report error, but can still alloc an