2014-03-12 20:40 GMT+08:00 Eric Blake :
> On 03/11/2014 09:10 PM, Chunyan Liu wrote:
>
>
> >>> Could be if changing qemu_opt_get return value type, but just as said
> >>> before,
> >>> that will affect many codes.
> >>
> >> Also, changing an existing function that returns 'const char *' into
2014-03-18 3:35 GMT+08:00 Leandro Dorileo :
> Hi,
>
> On Mon, Mar 10, 2014 at 03:31:41PM +0800, Chunyan Liu wrote:
> > Add some qemu_opt functions to replace the same functionality of
> > QEMUOptionParameter handling.
> >
> > Signed-off-by: Dong Xu Wang
> > Signed-off-by: Chunyan Liu
> > ---
> >
Hi,
On Mon, Mar 10, 2014 at 03:31:41PM +0800, Chunyan Liu wrote:
> Add some qemu_opt functions to replace the same functionality of
> QEMUOptionParameter handling.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> include/qemu/option.h | 9 +++
> util/qemu-option.c| 18
2014-03-12 20:40 GMT+08:00 Eric Blake :
> On 03/11/2014 09:10 PM, Chunyan Liu wrote:
>
>
> >>> Could be if changing qemu_opt_get return value type, but just as said
> >>> before,
> >>> that will affect many codes.
> >>
> >> Also, changing an existing function that returns 'const char *' into
On 03/11/2014 09:10 PM, Chunyan Liu wrote:
>>> Could be if changing qemu_opt_get return value type, but just as said
>>> before,
>>> that will affect many codes.
>>
>> Also, changing an existing function that returns 'const char *' into now
>> returning 'char *' will NOT break any callers if
2014-03-11 19:59 GMT+08:00 Eric Blake :
> On 03/10/2014 11:29 PM, Chunyan Liu wrote:
> >>
> >> Why are your later callers using a common helper function, but
> >> qemu_opt_get_del() repeating a lot of the body of qemu_opt_get()?
> >> Shouldn't qemu_opt_get() and qemu_opt_get_del() call into a comm
On 03/10/2014 11:29 PM, Chunyan Liu wrote:
>>
>> Why are your later callers using a common helper function, but
>> qemu_opt_get_del() repeating a lot of the body of qemu_opt_get()?
>> Shouldn't qemu_opt_get() and qemu_opt_get_del() call into a common helper?
>>
>> qemu_opt_get_del must return (char
2014-03-11 7:28 GMT+08:00 Eric Blake :
> On 03/10/2014 01:31 AM, Chunyan Liu wrote:
> > Add some qemu_opt functions to replace the same functionality of
> > QEMUOptionParameter handling.
> >
> > Signed-off-by: Dong Xu Wang
> > Signed-off-by: Chunyan Liu
> > ---
> > include/qemu/option.h | 9 +
On 03/10/2014 01:31 AM, Chunyan Liu wrote:
> Add some qemu_opt functions to replace the same functionality of
> QEMUOptionParameter handling.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> include/qemu/option.h | 9 +++
> util/qemu-option.c| 188
> ++
Add some qemu_opt functions to replace the same functionality of
QEMUOptionParameter handling.
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
include/qemu/option.h | 9 +++
util/qemu-option.c| 188 ++
2 files changed, 184 inserti
10 matches
Mail list logo
