Re: [Qemu-devel] [PATCH v23 04/32] change opt->name and opt->str from (const char *) to (char *)

2014-03-25 Thread Eric Blake
On 03/21/2014 04:12 AM, Chunyan Liu wrote: Your subject says "what", but your commit message lacks a "why". Without a good reason, it's hard to see what this patch is good for. May I suggest: qemu_opt_del() already assumes that all QemuOpt instances contain malloc'd name and value; but it had to

Re: [Qemu-devel] [PATCH v23 04/32] change opt->name and opt->str from (const char *) to (char *)

2014-03-25 Thread Leandro Dorileo
On Fri, Mar 21, 2014 at 06:12:15PM +0800, Chunyan Liu wrote: > Signed-off-by: Chunyan Liu > --- > include/qemu/option_int.h | 4 ++-- > qapi/opts-visitor.c | 10 +++--- > util/qemu-option.c| 4 ++-- > 3 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/include/

[Qemu-devel] [PATCH v23 04/32] change opt->name and opt->str from (const char *) to (char *)

2014-03-21 Thread Chunyan Liu
Signed-off-by: Chunyan Liu --- include/qemu/option_int.h | 4 ++-- qapi/opts-visitor.c | 10 +++--- util/qemu-option.c| 4 ++-- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/include/qemu/option_int.h b/include/qemu/option_int.h index 8212fa4..db9ed91 100644 -