Re: [Qemu-devel] [PATCH v3] Add getsockopt for settable SOL_IPV6 options

2019-01-06 Thread Laurent Vivier
Le 07/01/2019 à 06:50, Tom Deseyn a écrit : > Hi Laurent, > > Can you please take a look at the updated patch? Should I add braces for > code-style? Yes, new code must follow code-style. Older is only updated when we modify it for something else. Thanks, Laurent

Re: [Qemu-devel] [PATCH v3] Add getsockopt for settable SOL_IPV6 options

2019-01-06 Thread Tom Deseyn
Hi Laurent, Can you please take a look at the updated patch? Should I add braces for code-style? Thanks, Tom On Fri, Dec 14, 2018 at 4:43 PM wrote: > From: Tom Deseyn > > Thank you for reviewing Laurant. > Sorry for missing history, I'm not used to sending patches via mail. > I got an email

Re: [Qemu-devel] [PATCH v3] Add getsockopt for settable SOL_IPV6 options

2018-12-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20181214154130.4069-1-tom.des...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181214154130.4069-1-tom.des...@gmail.com Type: series Subject: [Qemu-devel] [PATCH v3] Add

[Qemu-devel] [PATCH v3] Add getsockopt for settable SOL_IPV6 options

2018-12-14 Thread tom . deseyn
From: Tom Deseyn Thank you for reviewing Laurant. Sorry for missing history, I'm not used to sending patches via mail. I got an email about code style. For now, I'm sticking to the style that is used in the function. v2: default to unimplemented v3: match kernel behavior Signed-off-by: Tom Dese