Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-30 Thread Eduardo Habkost
On Thu, Mar 30, 2017 at 05:26:26PM +0200, Andrew Jones wrote: > On Thu, Mar 30, 2017 at 12:00:48PM -0300, Eduardo Habkost wrote: > > On Wed, Mar 29, 2017 at 02:30:38PM +0200, Andrew Jones wrote: > > > On Wed, Mar 29, 2017 at 01:44:58PM +0200, Igor Mammedov wrote: > > > > On Wed, 29 Mar 2017

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-30 Thread Andrew Jones
On Thu, Mar 30, 2017 at 12:00:48PM -0300, Eduardo Habkost wrote: > On Wed, Mar 29, 2017 at 02:30:38PM +0200, Andrew Jones wrote: > > On Wed, Mar 29, 2017 at 01:44:58PM +0200, Igor Mammedov wrote: > > > On Wed, 29 Mar 2017 16:50:00 +0800 > > > He Chen wrote: > > > > > >

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-30 Thread Eduardo Habkost
On Wed, Mar 29, 2017 at 02:30:38PM +0200, Andrew Jones wrote: > On Wed, Mar 29, 2017 at 01:44:58PM +0200, Igor Mammedov wrote: > > On Wed, 29 Mar 2017 16:50:00 +0800 > > He Chen wrote: > > > > > +static void default_numa_distance(void) > > > > > +{ > > > > > +int src,

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-29 Thread Andrew Jones
On Wed, Mar 29, 2017 at 01:44:58PM +0200, Igor Mammedov wrote: > On Wed, 29 Mar 2017 16:50:00 +0800 > He Chen wrote: > > > > +static void default_numa_distance(void) > > > > +{ > > > > +int src, dst; > > > > + > > > fill in defaults only if there weren't any '-numa

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-29 Thread Igor Mammedov
On Wed, 29 Mar 2017 16:50:00 +0800 He Chen wrote: > On Thu, Mar 23, 2017 at 10:29:55AM +0100, Igor Mammedov wrote: > > On Wed, 22 Mar 2017 17:32:46 +0800 > > He Chen wrote: > > > > > Current, QEMU does not provide a clear command to set vNUMA

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-29 Thread He Chen
On Thu, Mar 23, 2017 at 10:29:55AM +0100, Igor Mammedov wrote: > On Wed, 22 Mar 2017 17:32:46 +0800 > He Chen wrote: > > > Current, QEMU does not provide a clear command to set vNUMA distance for > > guest although we already have `-numa` command to set vNUMA nodes. > >

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-23 Thread Eric Blake
On 03/23/2017 02:23 AM, He Chen wrote: >>> -numa dist,src=1,dst=0,val=21 \ >> >> And maybe should also point out how to set an unreachable node with 255. >> > Thanks for your careful review. Regarding setting unreachable node, > which way is good? Set exact 255 as distance or distance that is

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-23 Thread Igor Mammedov
On Wed, 22 Mar 2017 17:32:46 +0800 He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we already have `-numa` command to set vNUMA nodes. > > vNUMA distance makes sense in certain scenario. > But now, if we create

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-23 Thread Andrew Jones
On Thu, Mar 23, 2017 at 03:23:35PM +0800, He Chen wrote: > > > > And maybe should also point out how to set an unreachable node with 255. > > > Thanks for your careful review. Regarding setting unreachable node, > which way is good? Set exact 255 as distance or distance that is larger > than 255

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-23 Thread He Chen
On Wed, Mar 22, 2017 at 11:34:05AM +0100, Andrew Jones wrote: > > You should have CC'ed me, considering this version is addressing my > review comments, but whatever, I usually skim the list so I found it... > > On Wed, Mar 22, 2017 at 05:32:46PM +0800, He Chen wrote: > > Current, QEMU does not

Re: [Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-22 Thread Andrew Jones
You should have CC'ed me, considering this version is addressing my review comments, but whatever, I usually skim the list so I found it... On Wed, Mar 22, 2017 at 05:32:46PM +0800, He Chen wrote: > Current, QEMU does not provide a clear command to set vNUMA distance for > guest although we

[Qemu-devel] [PATCH v3] Allow setting NUMA distance for different NUMA nodes

2017-03-22 Thread He Chen
Current, QEMU does not provide a clear command to set vNUMA distance for guest although we already have `-numa` command to set vNUMA nodes. vNUMA distance makes sense in certain scenario. But now, if we create a guest that has 4 vNUMA nodes, when we check NUMA info via `numactl -H`, we will see: