Re: [Qemu-devel] [PATCH v3] Move File operations to qemu-file.c

2013-03-13 Thread Joel Schopp
-util-obj-y = util/ qobject/ qapi/ trace/ +util-obj-y = util/ qobject/ qapi/ trace/ qemu-file.o Please either move it to util/ (and the include file to include/qemu/file.h), or leave it in common-obj-y. I prefer the former, since as a rule of thumb util-obj-y includes code that should be easy

Re: [Qemu-devel] [PATCH v3] Move File operations to qemu-file.c

2013-03-13 Thread Paolo Bonzini
Il 12/03/2013 23:43, Joel Schopp ha scritto: > This patch reorganizes qemu file operations to be in their own source file > instead of being lumped in savevm.c. Besides being more logical for > maintenance > it also makes it easier for future users of the file functions to add tests. > > v3 forw

[Qemu-devel] [PATCH v3] Move File operations to qemu-file.c

2013-03-12 Thread Joel Schopp
This patch reorganizes qemu file operations to be in their own source file instead of being lumped in savevm.c. Besides being more logical for maintenance it also makes it easier for future users of the file functions to add tests. v3 forward port to resolve conflicts v2 forward port to resolve c