Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-08 Thread Eric Blake
On 09/08/2016 10:30 AM, Ashijeet Acharya wrote: +if (has_downtime_limit) { +downtime_limit *= 100; /* convert to nanoseconds */ >>> >>> Are you sure this won't overflow? >> >> Ashijeet, Eric mere means that if downtime_limit is bigger that >> INT64_MAX/100, then you

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-08 Thread Juan Quintela
Eric Blake wrote: >> +if (has_max_bandwidth) { >> +s->parameters.max_bandwidth = max_bandwidth; >> +if (s->to_dst_file) { >> +qemu_file_set_rate_limit(s->to_dst_file, >> +s->parameters.max_bandwidth / >>

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-08 Thread Ashijeet Acharya
On Thu, Sep 8, 2016 at 8:11 PM, Juan Quintela wrote: > Eric Blake wrote: > >>> +if (has_max_bandwidth) { >>> +s->parameters.max_bandwidth = max_bandwidth; >>> +if (s->to_dst_file) { >>> +

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-08 Thread Ashijeet Acharya
On Thu, Sep 8, 2016 at 3:33 AM, Eric Blake wrote: > On 09/06/2016 08:39 AM, Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> setting maximum migration speed and

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-07 Thread Eric Blake
On 09/06/2016 08:39 AM, Ashijeet Acharya wrote: > Mark old-commands for speed and downtime as deprecated. > Move max-bandwidth and downtime-limit into migrate-set-parameters for > setting maximum migration speed and expected downtime limit parameters > respectively. > Change downtime units to

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-07 Thread Ashijeet Acharya
On Wed, Sep 7, 2016 at 2:11 PM, Juan Quintela wrote: > Ashijeet Acharya wrote: >> Mark old-commands for speed and downtime as deprecated. >> Move max-bandwidth and downtime-limit into migrate-set-parameters for >> setting maximum migration speed

Re: [Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-07 Thread Juan Quintela
Ashijeet Acharya wrote: > Mark old-commands for speed and downtime as deprecated. > Move max-bandwidth and downtime-limit into migrate-set-parameters for > setting maximum migration speed and expected downtime limit parameters > respectively. > Change downtime units to

[Qemu-devel] [PATCH v3] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp

2016-09-06 Thread Ashijeet Acharya
Mark old-commands for speed and downtime as deprecated. Move max-bandwidth and downtime-limit into migrate-set-parameters for setting maximum migration speed and expected downtime limit parameters respectively. Change downtime units to milliseconds (only for new-command) and update the query part