Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-27 Thread Robert Wang
I re-sent the patch and use bdrv_co_flush now, thanks. 2011/10/27 shu ming : > Looks good to me.  A nit, it seems that bdrv_flush is not supported anymore > in upstream. > bdrv_co_flush should be used instead if you update your workspace to latest > one. > On 2011-10-26 18:08, Robert Wang wrote: >

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-27 Thread Dong Xu Wang
Re-sent it, thanks. 2011/10/27 Stefan Hajnoczi : > On Wed, Oct 26, 2011 at 06:08:03PM +0800, Robert Wang wrote: >> Please find version 4 in the attachment. > > Please send patches inline instead of attaching them.  It makes it > easier to reply with feedback. > > If you want to add extra comments

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-27 Thread Stefan Hajnoczi
On Wed, Oct 26, 2011 at 06:08:03PM +0800, Robert Wang wrote: > Please find version 4 in the attachment. Please send patches inline instead of attaching them. It makes it easier to reply with feedback. If you want to add extra comments that should not be included in the git commit you can add it

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-26 Thread shu ming
Looks good to me. A nit, it seems that bdrv_flush is not supported anymore in upstream. bdrv_co_flush should be used instead if you update your workspace to latest one. On 2011-10-26 18:08, Robert Wang wrote: Please find version 4 in the attachment. 2011/10/23 shu ming: On 2011-10-13 0:23, D

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-26 Thread Robert Wang
Please find version 4 in the attachment. 2011/10/23 shu ming : > On 2011-10-13 0:23, Dong Xu Wang wrote: >> >> Add add-cow file format >> >> Signed-off-by: Dong Xu Wang >> --- >>  Makefile.objs          |    1 + >>  block.c                |    2 +- >>  block.h                |    1 + >>  block/add

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-23 Thread shu ming
On 2011-10-13 0:23, Dong Xu Wang wrote: Add add-cow file format Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 412 block_int.h

Re: [Qemu-devel] [PATCH v3] add add-cow file format

2011-10-13 Thread Dong Xu Wang
On Thu 13 Oct 2011 12:23:16 AM CST, Dong Xu Wang wrote: Add add-cow file format Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 412

[Qemu-devel] [PATCH v3] add add-cow file format

2011-10-12 Thread Dong Xu Wang
Add add-cow file format Signed-off-by: Dong Xu Wang --- Makefile.objs |1 + block.c|2 +- block.h|1 + block/add-cow.c| 412 block_int.h|1 + docs/specs/add-cow.txt |