Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-10-28 Thread Jeff Cody
On Tue, Sep 27, 2016 at 07:14:52PM +0800, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the

Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Eric Blake
On 09/27/2016 06:14 AM, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use

Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Eric Blake
On 09/27/2016 06:14 AM, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify use

[Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Fam Zheng
We already specified BDRV_O_UNMAP when opening images in 'qemu-img commit', but didn't turn on the "unmap" in the active commit job. This patch fixes that so that zeroed clusters in top image can be discarded which is desired in the virt-sparsify use case, where a temporary overlay is created and f