Re: [Qemu-devel] [PATCH v3] build: include sys/sysmacros.h for major() and minor()

2017-03-14 Thread Peter Maydell
On 28 December 2016 at 21:04, Christopher Covington wrote: > The definition of the major() and minor() macros are moving within glibc to > . Include this header when it is available to avoid the > following sorts of build-stopping messages: > > qga/commands-posix.c: In

Re: [Qemu-devel] [PATCH v3] build: include sys/sysmacros.h for major() and minor()

2017-03-13 Thread Eric Blake
On 12/29/2016 08:03 AM, Eric Blake wrote: > On 12/28/2016 02:04 PM, Christopher Covington wrote: > > It's best when posting a v3 to do so as a new thread, rather than buried > in-reply-to an earlier thread, as some maintainers' tools overlook > deeply-threaded patches. Probably won't matter too

Re: [Qemu-devel] [PATCH v3] build: include sys/sysmacros.h for major() and minor()

2016-12-29 Thread Eric Blake
On 12/28/2016 02:04 PM, Christopher Covington wrote: It's best when posting a v3 to do so as a new thread, rather than buried in-reply-to an earlier thread, as some maintainers' tools overlook deeply-threaded patches. Probably won't matter too much in this case, but it's useful information for

[Qemu-devel] [PATCH v3] build: include sys/sysmacros.h for major() and minor()

2016-12-28 Thread Christopher Covington
The definition of the major() and minor() macros are moving within glibc to . Include this header when it is available to avoid the following sorts of build-stopping messages: qga/commands-posix.c: In function ‘dev_major_minor’: qga/commands-posix.c:656:13: error: In the GNU C Library, "major" is