Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-20 Thread Pradeep Jagadeesh
On 10/20/2016 2:50 PM, Alberto Garcia wrote: On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote: One more update is, I had a look at bdrv_io_limits_intercept and I just removed lock and retained other two things pending_reqs,any_timer_armed It works fine. So you managed to make it w

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-20 Thread Pradeep Jagadeesh
On 10/20/2016 3:32 PM, Greg Kurz wrote: On Thu, 20 Oct 2016 14:50:29 +0200 Alberto Garcia wrote: On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote: One more update is, I had a look at bdrv_io_limits_intercept and I just removed lock and retained other two things pending_reqs,any_t

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-20 Thread Greg Kurz
On Thu, 20 Oct 2016 14:50:29 +0200 Alberto Garcia wrote: > On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote: > > > One more update is, I had a look at bdrv_io_limits_intercept and I > > just removed lock and retained other two things > > pending_reqs,any_timer_armed It works fine.

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-20 Thread Alberto Garcia
On Wed 19 Oct 2016 06:29:45 PM CEST, Pradeep Jagadeesh wrote: > One more update is, I had a look at bdrv_io_limits_intercept and I > just removed lock and retained other two things > pending_reqs,any_timer_armed It works fine. So you managed to make it work without the lock? Can you post the new

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-19 Thread Pradeep Jagadeesh
On 10/18/2016 6:19 PM, Alberto Garcia wrote: On Mon 17 Oct 2016 11:19:11 AM CEST, Pradeep Jagadeesh wrote: +typedef struct FsThrottle { +ThrottleState ts; +ThrottleTimers tt; +AioContext *aioctx; +ThrottleConfig cfg; +bool enabled; +CoQueue throttled_reqs[2]; +

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-19 Thread Pradeep Jagadeesh
On 10/18/2016 6:19 PM, Alberto Garcia wrote: On Mon 17 Oct 2016 11:19:11 AM CEST, Pradeep Jagadeesh wrote: +typedef struct FsThrottle { +ThrottleState ts; +ThrottleTimers tt; +AioContext *aioctx; +ThrottleConfig cfg; +bool enabled; +CoQueue throttled_reqs[2]; +

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-18 Thread Alberto Garcia
On Mon 17 Oct 2016 11:19:11 AM CEST, Pradeep Jagadeesh wrote: >>> +typedef struct FsThrottle { >>> +ThrottleState ts; >>> +ThrottleTimers tt; >>> +AioContext *aioctx; >>> +ThrottleConfig cfg; >>> +bool enabled; >>> +CoQueue throttled_reqs[2]; >>> +unsigned pe

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-10-17 Thread Pradeep Jagadeesh
Hi Alberto, On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: --- a/fsdev/qemu-fsdev-opts.c +++ b/fsdev/qemu-fsdev-opts.c @@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = { }, { .name =

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-22 Thread Pradeep Jagadeesh
Hi Greg, On Wed, 21 Sep 2016 12:22:25 +0200 Pradeep Jagadeesh wrote: Hi Greg, Thanks for having a look at patchset. See the replies below. On Fri, 16 Sep 2016 04:33:36 -0400 Pradeep Jagadeesh wrote: Uses throttling APIs to limit I/O bandwidth and number of operations on the fsdev device

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-22 Thread Pradeep Jagadeesh
Hi Alberto, On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: --- a/fsdev/qemu-fsdev-opts.c +++ b/fsdev/qemu-fsdev-opts.c @@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = { }, { .name

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-21 Thread Greg Kurz
On Wed, 21 Sep 2016 12:22:25 +0200 Pradeep Jagadeesh wrote: > Hi Greg, > > Thanks for having a look at patchset. > See the replies below. > > > On Fri, 16 Sep 2016 04:33:36 -0400 > > Pradeep Jagadeesh wrote: > > > >> Uses throttling APIs to limit I/O bandwidth and number of operations on the

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-21 Thread Pradeep Jagadeesh
Hi Greg, Thanks for having a look at patchset. See the replies below. On Fri, 16 Sep 2016 04:33:36 -0400 Pradeep Jagadeesh wrote: Uses throttling APIs to limit I/O bandwidth and number of operations on the fsdev devices. Signed-off-by: Pradeep Jagadeesh --- Hi Pradeep, Please find some

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-20 Thread Greg Kurz
On Fri, 16 Sep 2016 04:33:36 -0400 Pradeep Jagadeesh wrote: > Uses throttling APIs to limit I/O bandwidth and number of operations on the > fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > --- Hi Pradeep, Please find some comments below. > fsdev/Makefile.objs | 1 + > fsdev/

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-20 Thread Greg Kurz
On Tue, 20 Sep 2016 11:02:07 +0200 Pradeep Jagadeesh wrote: > Hi Alberto, > Hi, > Thanks for having look at the patch. > My replies are inline. > > On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: > > > > Hi, > > > > first of all, sorry for the late reply! Here are my comments:

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-20 Thread Pradeep Jagadeesh
Hi Alberto, Thanks for having look at the patch. My replies are inline. On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: No problem! --- a/fsdev/qemu-fsdev-opts.c +++ b/fsdev/qemu-fsdev-opts.c @@ -37,6 +37,82 @@

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-19 Thread Alberto Garcia
On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: > --- a/fsdev/qemu-fsdev-opts.c > +++ b/fsdev/qemu-fsdev-opts.c > @@ -37,6 +37,82 @@ static QemuOptsList qemu_fsdev_opts = { > }, { > .name = "soc

[Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-16 Thread Pradeep Jagadeesh
Uses throttling APIs to limit I/O bandwidth and number of operations on the fsdev devices. Signed-off-by: Pradeep Jagadeesh --- fsdev/Makefile.objs | 1 + fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 76 ++ fsdev/qemu-fsdev-throttle.c | 191 +