Re: [Qemu-devel] [PATCH v3] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Peter Maydell
On 20 January 2014 14:20, Alon Levy wrote: > Several small signedness / overflow corrections to qxl_create_guest_primary: > 1. use 64 bit unsigned for size to avoid overflow possible from two 32 > bit multiplicants. > 2. correct sign for requested_height > 3. add a more verbose error message when

[Qemu-devel] [PATCH v3] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Alon Levy
Several small signedness / overflow corrections to qxl_create_guest_primary: 1. use 64 bit unsigned for size to avoid overflow possible from two 32 bit multiplicants. 2. correct sign for requested_height 3. add a more verbose error message when setting guest bug state (which causes a complete guess