Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-26 Thread Gerd Hoffmann
On Mi, 2017-01-25 at 18:36 +0100, Phil Dennis-Jordan wrote: > On 25 January 2017 at 18:27, wrote: > > Your series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Subject: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Fam Zheng
On Thu, 01/26 07:29, Markus Armbruster wrote: > With QEMU sources, you can have any tab width, as long as it is eight. That is very permissive! Fam

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 01/25 18:36, Phil Dennis-Jordan wrote: >> On 25 January 2017 at 18:27, wrote: >> > Your series seems to have some coding style problems. See output below for >> > more information: >> > >> > Type: series >> > Su

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Fam Zheng
On Wed, 01/25 18:36, Phil Dennis-Jordan wrote: > On 25 January 2017 at 18:27, wrote: > > Your series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Im

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Phil Dennis-Jordan
On 25 January 2017 at 18:27, wrote: > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility > of usb-tablet > Message-id: 1485365075-327

Re: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet Message-id: 1485365075-32702-1-git-send-email-p...@philjordan.eu === TEST SCRIPT BEGIN

[Qemu-devel] [PATCH v3] hw/usb/dev-hid: Improve guest compatibility of usb-tablet

2017-01-25 Thread Phil Dennis-Jordan
1. Set bInterfaceProtocol to 0x00 for usb-tablet. This should be non-zero for boot protocol devices only, which the usb-tablet is not. 2. Set the usb-tablet's usage to "mouse" in the report descriptor. The boot protocol of 0x02 specifically confused OS X/macOS' HID driver stack, causing it to