Re: [Qemu-devel] [PATCH v3] mirror: correct buf_size

2015-05-15 Thread Paolo Bonzini
On 15/05/2015 08:53, Wen Congyang wrote: > On 05/15/2015 02:45 PM, Paolo Bonzini wrote: >> >> >> On 15/05/2015 03:37, Wen Congyang wrote: >>> If bus_size is less than 0, the command fails. >>> If buf_size % granularity is not 0, mirror_free_init() will >>> do dangerous things. >>> >>> Signed-off-

Re: [Qemu-devel] [PATCH v3] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
On 05/15/2015 02:45 PM, Paolo Bonzini wrote: > > > On 15/05/2015 03:37, Wen Congyang wrote: >> If bus_size is less than 0, the command fails. >> If buf_size % granularity is not 0, mirror_free_init() will >> do dangerous things. >> >> Signed-off-by: Wen Congyang >> --- >> block/mirror.c | 6 +++

Re: [Qemu-devel] [PATCH v3] mirror: correct buf_size

2015-05-14 Thread Paolo Bonzini
On 15/05/2015 03:37, Wen Congyang wrote: > If bus_size is less than 0, the command fails. > If buf_size % granularity is not 0, mirror_free_init() will > do dangerous things. > > Signed-off-by: Wen Congyang > --- > block/mirror.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH v3] mirror: correct buf_size

2015-05-14 Thread Fam Zheng
On Fri, 05/15 09:37, Wen Congyang wrote: > If bus_size is less than 0, the command fails. > If buf_size % granularity is not 0, mirror_free_init() will > do dangerous things. > > Signed-off-by: Wen Congyang > --- > block/mirror.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >

[Qemu-devel] [PATCH v3] mirror: correct buf_size

2015-05-14 Thread Wen Congyang
If bus_size is less than 0, the command fails. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang --- block/mirror.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 58f391a..7