Re: [Qemu-devel] [PATCH v3] network scripts: don't block SIGCHLD before forking

2011-12-15 Thread Anthony Liguori
On 12/07/2011 09:48 PM, Michael Roth wrote: This patch fixes a bug where child processes of launch_script() can misbehave due to SIGCHLD being blocked. In the case of `sudo`, this causes a permanent hang. Previously a SIGCHLD handler was added to reap fork_exec()'d zombie processes by calling wa

Re: [Qemu-devel] [PATCH v3] network scripts: don't block SIGCHLD before forking

2011-12-12 Thread Paolo Bonzini
On 12/08/2011 04:48 AM, Michael Roth wrote: This patch fixes a bug where child processes of launch_script() can misbehave due to SIGCHLD being blocked. In the case of `sudo`, this causes a permanent hang. Previously a SIGCHLD handler was added to reap fork_exec()'d zombie processes by calling wa

Re: [Qemu-devel] [PATCH v3] network scripts: don't block SIGCHLD before forking

2011-12-08 Thread Jan Kiszka
On 2011-12-08 04:48, Michael Roth wrote: > This patch fixes a bug where child processes of launch_script() can > misbehave due to SIGCHLD being blocked. In the case of `sudo`, this > causes a permanent hang. > > Previously a SIGCHLD handler was added to reap fork_exec()'d zombie > processes by cal

[Qemu-devel] [PATCH v3] network scripts: don't block SIGCHLD before forking

2011-12-07 Thread Michael Roth
This patch fixes a bug where child processes of launch_script() can misbehave due to SIGCHLD being blocked. In the case of `sudo`, this causes a permanent hang. Previously a SIGCHLD handler was added to reap fork_exec()'d zombie processes by calling waitpid(-1, ...). This required other fork()/wai