Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-19 Thread Amos Kong
On Wed, May 16, 2012 at 11:26 PM, Bjorn Helgaas bhelg...@google.com wrote: On Fri, May 11, 2012 at 8:00 AM, Jiang Liu liu...@gmail.com wrote: On 05/11/2012 08:24 AM, Amos Kong wrote: On 05/11/2012 07:54 AM, Amos Kong wrote: On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote: On Fri, May 11,

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-16 Thread Bjorn Helgaas
On Fri, May 11, 2012 at 8:00 AM, Jiang Liu liu...@gmail.com wrote: On 05/11/2012 08:24 AM, Amos Kong wrote: On 05/11/2012 07:54 AM, Amos Kong wrote: On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote: On 05/10/2012 11:44 PM, Amos Kong

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-11 Thread Jiang Liu
On 05/11/2012 08:24 AM, Amos Kong wrote: On 05/11/2012 07:54 AM, Amos Kong wrote: On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote: On 05/10/2012 11:44 PM, Amos Kong wrote: diff --git a/drivers/pci/hotplug/acpiphp_glue.c

[Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-10 Thread Amos Kong
Hotplug CallTrace: int acpiphp_enable_slot(struct acpiphp_slot *slot) \_enable_device(slot); \_pci_bus_add_devices(bus); # un-added new devs(all funcs in slot) will be added list_for_each_entry(dev, bus-devices, bus_list) { if (dev-is_added)

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-10 Thread Michael S. Tsirkin
On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote: On 05/10/2012 11:44 PM, Amos Kong wrote: diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 806c44f..a7442d9 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-10 Thread Jiang Liu
On 05/10/2012 11:44 PM, Amos Kong wrote: diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 806c44f..a7442d9 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -885,7 +885,7 @@ static void

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-10 Thread Amos Kong
On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote: On 05/10/2012 11:44 PM, Amos Kong wrote: diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 806c44f..a7442d9 100644 ---

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-10 Thread Amos Kong
On 05/11/2012 07:54 AM, Amos Kong wrote: On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote: On 05/10/2012 11:44 PM, Amos Kong wrote: diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index