Re: [Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

2013-11-13 Thread Fam Zheng
On 2013年11月13日 20:43, Kevin Wolf wrote: From: Fam Zheng This patch moves ret assignment after reporting original error. We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" mismatch offset. This fixes two bug

Re: [Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

2013-11-13 Thread Eric Blake
On 11/13/2013 05:43 AM, Kevin Wolf wrote: > From: Fam Zheng > > This patch moves ret assignment after reporting original error. > > We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when > I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" > mismatch offset. This

[Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

2013-11-13 Thread Kevin Wolf
From: Fam Zheng This patch moves ret assignment after reporting original error. We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" mismatch offset. This fixes two bugs. In the first if branch, setting ret to