Re: [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl

2010-01-14 Thread Cole Robinson
On 01/14/2010 05:45 AM, malc wrote: > On Wed, 13 Jan 2010, Cole Robinson wrote: > >> On 01/13/2010 07:11 PM, malc wrote: >>> On Wed, 13 Jan 2010, Cole Robinson wrote: >>> Current CDROM detection is hardcoded based on source file name. Make this smarter by attempting a CDROM specific ioct

Re: [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl

2010-01-14 Thread malc
On Wed, 13 Jan 2010, Cole Robinson wrote: > On 01/13/2010 07:11 PM, malc wrote: > > On Wed, 13 Jan 2010, Cole Robinson wrote: > > > >> Current CDROM detection is hardcoded based on source file name. > >> Make this smarter by attempting a CDROM specific ioctl. > >> > >> This makes '-cdrom /dev/sr0

Re: [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl

2010-01-13 Thread Cole Robinson
On 01/13/2010 07:11 PM, malc wrote: > On Wed, 13 Jan 2010, Cole Robinson wrote: > >> Current CDROM detection is hardcoded based on source file name. >> Make this smarter by attempting a CDROM specific ioctl. >> >> This makes '-cdrom /dev/sr0' succeed with no media present. >> >> v2: >> Give io

Re: [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl

2010-01-13 Thread malc
On Wed, 13 Jan 2010, Cole Robinson wrote: > Current CDROM detection is hardcoded based on source file name. > Make this smarter by attempting a CDROM specific ioctl. > > This makes '-cdrom /dev/sr0' succeed with no media present. > > v2: > Give ioctl check higher priority than filename check

[Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl

2010-01-13 Thread Cole Robinson
Current CDROM detection is hardcoded based on source file name. Make this smarter by attempting a CDROM specific ioctl. This makes '-cdrom /dev/sr0' succeed with no media present. v2: Give ioctl check higher priority than filename check, v3: Actually initialize 'prio' variable Check