Re: [Qemu-devel] [PATCH v3] scripts: use git archive in archive-source

2019-01-31 Thread Gerd Hoffmann
Hi, > > tar_file=$(realpath "$1") > > -list_file="${tar_file}.list" > > -vroot_dir="${tar_file}.vroot" > > +sub_file=$(mktemp "${tar_file%.tar}.sub..tar") > > +sub_tdir=$(mktemp -d "${tar_file%.tar}.sub.") > > mktemp is not specified by POSIX; and FreeBSD man pages for mktemp >

Re: [Qemu-devel] [PATCH v3] scripts: use git archive in archive-source

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190131130016.17337-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190131130016.17337-1-kra...@redhat.com Subject: [Qemu-devel] [PATCH v3] scripts: use git archive in

Re: [Qemu-devel] [PATCH v3] scripts: use git archive in archive-source

2019-01-31 Thread Eric Blake
On 1/31/19 7:00 AM, Gerd Hoffmann wrote: > Use git archive to create tarballs of qemu and submodules instead of > cloning the repository and the submodules. This is a order of magnitude > faster because it doesn't fetch the submodules from the internet each > time the script runs. > > Signed-off-

[Qemu-devel] [PATCH v3] scripts: use git archive in archive-source

2019-01-31 Thread Gerd Hoffmann
Use git archive to create tarballs of qemu and submodules instead of cloning the repository and the submodules. This is a order of magnitude faster because it doesn't fetch the submodules from the internet each time the script runs. Signed-off-by: Gerd Hoffmann --- scripts/archive-source.sh | 6