Re: [Qemu-devel] [PATCH v3] target-mips: Clean up microMIPS32 major opcode

2012-11-24 Thread Aurelien Jarno
On Wed, Nov 21, 2012 at 02:04:41PM +0800, 陳韋任 (Wei-Ren Chen) wrote: > I check MIPS microMIPS manual [1], and found the major opcode might > be wrong. I add a comment to explicitly indicate what manual I am refering > to, and according that manual I remove microMIPS32 major opcodes 0x1f. > As for

Re: [Qemu-devel] [PATCH v3] target-mips: Clean up microMIPS32 major opcode

2012-11-20 Thread Johnson, Eric
> -Original Message- > From: 陳韋任 (Wei-Ren Chen) [mailto:che...@iis.sinica.edu.tw] > Sent: Tuesday, November 20, 2012 10:05 PM > To: qemu-devel@nongnu.org > Cc: Johnson, Eric; Aurelien Jarno; Jia Liu > Subject: [PATCH v3] target-mips: Clean up microMIPS32 major opcode > > I check MIPS mic

[Qemu-devel] [PATCH v3] target-mips: Clean up microMIPS32 major opcode

2012-11-20 Thread Wei-Ren Chen
I check MIPS microMIPS manual [1], and found the major opcode might be wrong. I add a comment to explicitly indicate what manual I am refering to, and according that manual I remove microMIPS32 major opcodes 0x1f. As for others, like 0x16, 0x17, 0x36 and 0x37, they are for higher-order MIPS ISA l