Re: [Qemu-devel] [PATCH v3] tcg-i386: Introduce limited deposit support

2011-09-29 Thread Richard Henderson
On 09/29/2011 08:23 AM, Jan Kiszka wrote: > +#ifndef TCG_TARGET_deposit_i32_valid > +#define TCG_TARGET_deposit_i32_valid(ofs, len) 0 > +#endif > +#ifndef TCG_TARGET_deposit_i64_valid > +#define TCG_TARGET_deposit_i64_valid(ofs, len) 0 > +#endif Err, no. The default is true. The targets that cur

[Qemu-devel] [PATCH v3] tcg-i386: Introduce limited deposit support

2011-09-29 Thread Jan Kiszka
x86 cannot provide an optimized generic deposit implementation. But at least for a few special cases, namely for writing bits 0..7, 8..15, and 0..15, versions using only a single instruction are feasible. Introducing such limited support improves emulating 16-bit x86 code on x86, but also rarer cas