Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line

2014-06-02 Thread Stefan Hajnoczi
On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote: > Allow selection of different card models from the qemu > command line, to better accomodate a wider range of guests. > > New in v3: > > - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with: > - s/TYPE_

Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line

2014-06-01 Thread Peter Crosthwaite
On Sun, Jun 1, 2014 at 1:33 PM, Gabriel L. Somlo wrote: > Allow selection of different card models from the qemu > command line, to better accomodate a wider range of guests. > > New in v3: > > - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with: > - s/TYPE_E1000/TYPE_

Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line

2014-06-01 Thread Michael S. Tsirkin
On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote: > Allow selection of different card models from the qemu > command line, to better accomodate a wider range of guests. Looks good to me. If possible pls address a nit I noted in one of the patches. Besides that: Reviewed-by

[Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line

2014-05-31 Thread Gabriel L. Somlo
Allow selection of different card models from the qemu command line, to better accomodate a wider range of guests. New in v3: - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with: - s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan - improved QOM-ification as