On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
>
> New in v3:
>
> - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with:
> - s/TYPE_
On Sun, Jun 1, 2014 at 1:33 PM, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
>
> New in v3:
>
> - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with:
> - s/TYPE_E1000/TYPE_
On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
Looks good to me.
If possible pls address a nit I noted in one of the patches.
Besides that:
Reviewed-by
Allow selection of different card models from the qemu
command line, to better accomodate a wider range of guests.
New in v3:
- 1/3 and 2/3 from v2 now merged into a single patch (1/3), with:
- s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan
- improved QOM-ification as