Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 15.02.2011 15:21, Peter Maydell wrote: > On 15 February 2011 14:03, Christophe Lyon wrote: >> It also seems that the neon_shl_s* helpers don't handle correctly large >> negative shift amounts. > > They look OK to me (large -ve shift is a huge right shift, > which for signed values should prop

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Peter Maydell
On 15 February 2011 14:03, Christophe Lyon wrote: > It also seems that the neon_shl_s* helpers don't handle correctly large > negative shift amounts. They look OK to me (large -ve shift is a huge right shift, which for signed values should propagate the sign bit to all bit positions, so we shift

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-15 Thread Christophe Lyon
On 14.02.2011 19:18, Peter Maydell wrote: > On 11 February 2011 15:10, wrote: >> From: Christophe Lyon >> >> This patch series provides fixes such that ARM Neon instructions >> VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now >> pass all my tests. >> >> I have reworked all the

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:10, wrote: > From: Christophe Lyon > > This patch series provides fixes such that ARM Neon instructions > VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now > pass all my tests. > > I have reworked all these patches and I hope they are now easier to > revi

[Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-11 Thread christophe.lyon
From: Christophe Lyon This patch series provides fixes such that ARM Neon instructions VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now pass all my tests. I have reworked all these patches and I hope they are now easier to review. Christophe Lyon (6): target-arm: Fix roundi