Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-02 Thread Stefan Hajnoczi
On Fri, Aug 02, 2013 at 10:22:13AM +0800, Fam Zheng wrote: > On Thu, 08/01 14:28, Stefan Hajnoczi wrote: > > On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: > > Follow-up question: > > > > Did you look at using bdrv_ref() for the BDS <- BlockJob relationship > > too? > > > > blockdev.c

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Fam Zheng
On Thu, 08/01 14:28, Stefan Hajnoczi wrote: > On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: > > BlockDriverState lifecycle management is needed by future features such as > > image fleecing and blockdev-add. This series adds reference count to > > BlockDriverState. > > > > The first t

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: > BlockDriverState lifecycle management is needed by future features such as > image fleecing and blockdev-add. This series adds reference count to > BlockDriverState. > > The first two patches clean up two odd BlockDriverState use cases,

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: > BlockDriverState lifecycle management is needed by future features such as > image fleecing and blockdev-add. This series adds reference count to > BlockDriverState. > > The first two patches clean up two odd BlockDriverState use cases,

[Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-07-31 Thread Fam Zheng
BlockDriverState lifecycle management is needed by future features such as image fleecing and blockdev-add. This series adds reference count to BlockDriverState. The first two patches clean up two odd BlockDriverState use cases, so all code uses bdrv_new() to create BlockDriverState instance. The