Re: [Qemu-devel] [PATCH v3 0/9] block: generic image streaming

2011-12-14 Thread Stefan Hajnoczi
On Wed, Dec 14, 2011 at 1:42 AM, Yibin Shen wrote: > On Tue, Dec 13, 2011 at 11:18 PM, Stefan Hajnoczi wrote: >> On Tue, Dec 13, 2011 at 2:12 PM, Yibin Shen wrote: >>> all these patches looks good to me except one thing, >>> when I run a "qemu-img commit" command, >>> seems entire image(from sta

Re: [Qemu-devel] [PATCH v3 0/9] block: generic image streaming

2011-12-13 Thread Yibin Shen
On Tue, Dec 13, 2011 at 11:18 PM, Stefan Hajnoczi wrote: > On Tue, Dec 13, 2011 at 2:12 PM, Yibin Shen wrote: >> all these patches looks good to me except one thing, >> when I run a "qemu-img commit" command, >> seems entire image(from start to end sector) will be write to the backing >> file, >

Re: [Qemu-devel] [PATCH v3 0/9] block: generic image streaming

2011-12-13 Thread Stefan Hajnoczi
On Tue, Dec 13, 2011 at 2:12 PM, Yibin Shen wrote: > all these patches looks good to me except one thing, > when I run a "qemu-img commit" command, > seems entire image(from start to end sector) will be write to the backing > file, > I think what we really need is to commit only dirty sectors. >

Re: [Qemu-devel] [PATCH v3 0/9] block: generic image streaming

2011-12-13 Thread Yibin Shen
hi stefan: all these patches looks good to me except one thing, when I run a "qemu-img commit" command, seems entire image(from start to end sector) will be write to the backing file, I think what we really need is to commit only dirty sectors. also maybe we can use a writeback mechanism alternaiv

[Qemu-devel] [PATCH v3 0/9] block: generic image streaming

2011-12-13 Thread Stefan Hajnoczi
This series adds the 'block_stream' command which copies the contents of a backing file into the image file while the VM is running. The series builds on copy-on-read and zero detection features which I sent out recently and I suggest grabbing my git tree to try it out without merging these depend