Re: [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field

2019-02-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190223000614.13894-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190223000614.13894-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate

Re: [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field

2019-02-25 Thread John Snow
On 2/22/19 7:06 PM, John Snow wrote: > The current internal meanings of "locked", "user_locked", > "qmp_locked", "frozen", "enabled", and "disabled" are all > a little muddled. > > Deprecate the @status field in favor of two new booleans > that carry very specific meanings. Then, rename and rew

[Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field

2019-02-22 Thread John Snow
The current internal meanings of "locked", "user_locked", "qmp_locked", "frozen", "enabled", and "disabled" are all a little muddled. Deprecate the @status field in favor of two new booleans that carry very specific meanings. Then, rename and rework some of the internal semantics to help make the