Re: [Qemu-devel] [PATCH v3 00/11] NBD reconnect

2018-07-03 Thread Eric Blake
On 07/03/2018 08:46 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. before v4 realization, I'd like to discuss some questions. Our proposal for v4 is the following: 1. don't reconnect on nbd_open. So, on open we do only one connect attempt, and if it fails, open fails. 2. don't configure tim

Re: [Qemu-devel] [PATCH v3 00/11] NBD reconnect

2018-07-03 Thread Vladimir Sementsov-Ogievskiy
Hi all. before v4 realization, I'd like to discuss some questions. Our proposal for v4 is the following: 1. don't reconnect on nbd_open. So, on open we do only one connect attempt, and if it fails, open fails. 2. don't configure timeout between attempts. instead do the following:     1s timeo

[Qemu-devel] [PATCH v3 00/11] NBD reconnect

2018-06-09 Thread Vladimir Sementsov-Ogievskiy
Hi all. Here is NBD reconnect. The feature realized inside nbd-client driver and works as follows: There are two parameters: reconnect-attempts and reconnect-timeout. So, we will try to reconnect in case of initial connection failed or in case of connection lost. All current and new io operations