Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 02:31 PM, Stefan Weil wrote: Commit 2f9cba0c148af32fad6813480f5c92efe17c2d49 re-added mmtimer2 because it had existed before (it was called "dynticks" and the default for w32) and was needed for Linux. It also added mmtimer, a multimedia timer without rearm. Yes, I missed that it

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-11-02 Thread Stefan Weil
Am 02.11.2011 13:54, schrieb Paolo Bonzini: On 10/31/2011 06:13 PM, Stefan Weil wrote: They can't be more broken: I noticed today that QEMU on W32 aborts with the default timer (mmtimer) very quickly. Is there any reason why mmtimer2 is not the default (or indeed why mmtimer and win32 exis

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-11-02 Thread Paolo Bonzini
On 10/31/2011 06:13 PM, Stefan Weil wrote: They can't be more broken: I noticed today that QEMU on W32 aborts with the default timer (mmtimer) very quickly. Is there any reason why mmtimer2 is not the default (or indeed why mmtimer and win32 exist)? Paolo

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-31 Thread Stefan Weil
Am 31.10.2011 11:05, schrieb Paolo Bonzini: On 10/31/2011 08:23 AM, TeLeMan wrote: >static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t) >{ > -if (!alarm_has_dynticks(t)) > +int64_t nearest_delta_ns; > +assert(alarm_has_dynticks(t)); "mmtimer" and "win32" alarms

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-31 Thread Paolo Bonzini
On 10/31/2011 08:23 AM, TeLeMan wrote: >static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t) >{ > -if (!alarm_has_dynticks(t)) > +int64_t nearest_delta_ns; > +assert(alarm_has_dynticks(t)); "mmtimer" and "win32" alarms have no rearm. Should we remove these two al

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-31 Thread TeLeMan
On Sat, Oct 22, 2011 at 00:26, Paolo Bonzini wrote: > Reviewed-by: Anthony Liguori > Signed-off-by: Paolo Bonzini > --- >  qemu-timer.c |  129 > -- >  1 files changed, 53 insertions(+), 76 deletions(-) > > diff --git a/qemu-timer.c b/qemu-

[Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-21 Thread Paolo Bonzini
Reviewed-by: Anthony Liguori Signed-off-by: Paolo Bonzini --- qemu-timer.c | 129 -- 1 files changed, 53 insertions(+), 76 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index acf7a15..e2551f3 100644 --- a/qemu-timer.c +++ b/qemu-t