Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, September 19, 2016 4:56 PM > Subject: Re: [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new > cryptodev backend > > On Mon, Sep 19, 2016 at 04:16:16PM +0800, Gonglei wrote: > > Signed-off-

Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Daniel P. Berrange
On Mon, Sep 19, 2016 at 04:16:16PM +0800, Gonglei wrote: > Signed-off-by: Gonglei > --- > crypto/Makefile.objs | 1 + > crypto/cryptodev-gcrypt.c | 329 > ++ > qemu-options.hx | 18 +++ > 3 files changed, 348 insertions(+) > create m

Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Gonglei (Arei)
Hi Daniel, > -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Monday, September 19, 2016 4:30 PM > Subject: Re: [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new > cryptodev backend > > AFAICT you are not using gcrypt here - you're using QEMU > c

Re: [Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Daniel P. Berrange
AFAICT you are not using gcrypt here - you're using QEMU cipher APIs (which is good). These APIs can be backed by either nettle or gcrypt though, so the subject is misleading. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org

[Qemu-devel] [PATCH v3 04/10] cryptodev: introduce gcrypt lib as a new cryptodev backend

2016-09-19 Thread Gonglei
Signed-off-by: Gonglei --- crypto/Makefile.objs | 1 + crypto/cryptodev-gcrypt.c | 329 ++ qemu-options.hx | 18 +++ 3 files changed, 348 insertions(+) create mode 100644 crypto/cryptodev-gcrypt.c diff --git a/crypto/Makefile.objs b/