Re: [Qemu-devel] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header

2018-06-17 Thread David Gibson
On Fri, Jun 15, 2018 at 04:04:39PM +0200, David Hildenbrand wrote: > Not used outside of pc-dimm.c and there shouldn't be other users. If > other devices (e.g. memory devices) ever have to also use slots, then we > will have to factor this out. > > Reviewed-by: Igor Mammedov > Signed-off-by: Davi

[Qemu-devel] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header

2018-06-15 Thread David Hildenbrand
Not used outside of pc-dimm.c and there shouldn't be other users. If other devices (e.g. memory devices) ever have to also use slots, then we will have to factor this out. Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/mem/pc-dimm.c | 4 +++- include/hw/mem/pc-dimm.h