Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs

2010-05-31 Thread Markus Armbruster
Gerd Hoffmann writes: >> pci_add nic -net use either the ID or option "name" of qemu_net_opts. >> And there's our hole. Reproducible with "-net user -net nic,id=foo >> -device lsi,id=foo". > > Oh. Well. Yes, better plug that. > >> @@ -242,6 +243,10 @@ DeviceState *qdev_device_add(QemuOpts *opt

Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs

2010-05-31 Thread Gerd Hoffmann
pci_add nic -net use either the ID or option "name" of qemu_net_opts. And there's our hole. Reproducible with "-net user -net nic,id=foo -device lsi,id=foo". Oh. Well. Yes, better plug that. @@ -242,6 +243,10 @@ DeviceState *qdev_device_add(QemuOpts *opts) qdev = qdev_create_from_info

Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs

2010-05-31 Thread Markus Armbruster
[cc: kraxel] Avi Kivity writes: > On 05/29/2010 11:01 AM, Markus Armbruster wrote: >> Jan Kiszka writes: >> >> >>> From: Jan Kiszka >>> >>> As the user may specify ambiguous device IDs, let's search for their >>> official names first before considering the user-supplied identifiers. >>> >>>

Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs

2010-05-30 Thread Avi Kivity
On 05/29/2010 11:01 AM, Markus Armbruster wrote: Jan Kiszka writes: From: Jan Kiszka As the user may specify ambiguous device IDs, let's search for their official names first before considering the user-supplied identifiers. Signed-off-by: Jan Kiszka The problem is letting the use

Re: [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs

2010-05-29 Thread Markus Armbruster
Jan Kiszka writes: > From: Jan Kiszka > > As the user may specify ambiguous device IDs, let's search for their > official names first before considering the user-supplied identifiers. > > Signed-off-by: Jan Kiszka The problem is letting the user specify ambiguous device IDs in the first place!

[Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs

2010-05-23 Thread Jan Kiszka
From: Jan Kiszka As the user may specify ambiguous device IDs, let's search for their official names first before considering the user-supplied identifiers. Signed-off-by: Jan Kiszka --- docs/qdev-device-use.txt |4 +++- hw/qdev.c| 18 +- 2 files changed,