Re: [Qemu-devel] [PATCH v3 05/16] tcg: Define tcg_insn_unit for codepointerss

2014-04-29 Thread Alex Bennée
Richard Henderson r...@twiddle.net writes: To be defined by the tcg backend based on the elemental unit of the ISA. During the transition, allow TCG_TARGET_INSN_UNIT_SIZE to be undefined, which allows us to default tcg_insn_unit to the current uint8_t. Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v3 05/16] tcg: Define tcg_insn_unit for codepointerss

2014-04-29 Thread Richard Henderson
On 04/29/2014 03:38 AM, Alex Bennée wrote: @@ -2653,7 +2683,8 @@ static inline int tcg_gen_code_common(TCGContext *s, uint8_t *gen_code_buf, } args += def-nb_args; next: -if (search_pc = 0 search_pc s-code_ptr - gen_code_buf) { +if (search_pc = 0 +

Re: [Qemu-devel] [PATCH v3 05/16] tcg: Define tcg_insn_unit for codepointerss

2014-04-29 Thread Richard Henderson
On 04/29/2014 03:38 AM, Alex Bennée wrote: next: -if (search_pc = 0 search_pc s-code_ptr - gen_code_buf) { +if (search_pc = 0 + search_pc (intptr_t)s-code_ptr - (intptr_t)gen_code_buf) { return op_index; } I thought we were