Re: [Qemu-devel] [PATCH v3 05/21] qapi: add QMP input visitor

2011-06-15 Thread Michael Roth
On 06/15/2011 11:11 AM, Luiz Capitulino wrote: On Mon, 13 Jun 2011 21:31:10 -0500 Michael Roth wrote: +Visitor *qmp_input_get_visitor(QmpInputVisitor *v) +{ +return&v->visitor; +} + +void qmp_input_visitor_cleanup(QmpInputVisitor *v) +{ You're not decrementing the reference to v->obj.

Re: [Qemu-devel] [PATCH v3 05/21] qapi: add QMP input visitor

2011-06-15 Thread Luiz Capitulino
On Wed, 15 Jun 2011 11:56:03 -0500 Michael Roth wrote: > On 06/15/2011 11:11 AM, Luiz Capitulino wrote: > > On Mon, 13 Jun 2011 21:31:10 -0500 > > Michael Roth wrote: > > > > >> +Visitor *qmp_input_get_visitor(QmpInputVisitor *v) > >> +{ > >> +return&v->visitor; > >> +} > >> + > >> +void qm

Re: [Qemu-devel] [PATCH v3 05/21] qapi: add QMP input visitor

2011-06-15 Thread Luiz Capitulino
On Mon, 13 Jun 2011 21:31:10 -0500 Michael Roth wrote: > A type of Visiter class that is used to walk a qobject's > structure and assign each entry to the corresponding native C type. > Command marshaling function will use this to pull out QMP command > parameters recieved over the wire and pass

[Qemu-devel] [PATCH v3 05/21] qapi: add QMP input visitor

2011-06-13 Thread Michael Roth
A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved over the wire and pass them as native arguments to the corresponding C functions. Signe