Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 09:34, Peter Maydell wrote: >> #define FMT_ERR "Error:%d" >> >> #define UINT8_P(ptr) ((uint8_t *) (ptr)) >> -#define UINT32_P(ptr) ((uint32_t *) (ptr)) >> +#define UINT32_P(ptr) ((uint32_t *) (size_t) (ptr)) >> #define PTR(var) UINT8_P(&var) > Hiding casts behind macros like this

Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-28 Thread Peter Maydell
On 28 November 2017 at 08:18, Ladi Prosek wrote: > On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov > wrote: >> Added some helper features for windbgstub. > --- a/include/exec/windbgstub-utils.h > +++ b/include/exec/windbgstub-utils.h > @@ -32,7 +32,7 @@ > #define FMT_ERR "Error:%d" > > #defi

Re: [Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-28 Thread Ladi Prosek
On Tue, Nov 21, 2017 at 3:07 PM, Mihail Abakumov wrote: > Added some helper features for windbgstub. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h | 27 +++ > include/exec/

[Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-21 Thread Mihail Abakumov
Added some helper features for windbgstub. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 27 +++ include/exec/windbgstub.h |6 ++ 2 files changed, 33 insertions(+) dif