Re: [Qemu-devel] [PATCH v3 06/11] fdc: do not call revalidate on eject

2015-12-18 Thread John Snow
On 12/18/2015 11:11 AM, Markus Armbruster wrote: > John Snow writes: > >> Currently, fd_revalidate is called in two different places, with two >> different expectations of behavior: >> >> (1) On initialization, as a routine to help pick the drive type and >> initial geometries as a side-eff

Re: [Qemu-devel] [PATCH v3 06/11] fdc: do not call revalidate on eject

2015-12-18 Thread Markus Armbruster
John Snow writes: > Currently, fd_revalidate is called in two different places, with two > different expectations of behavior: > > (1) On initialization, as a routine to help pick the drive type and > initial geometries as a side-effect of the pick_geometry routine > > (2) On insert/eject, wh

[Qemu-devel] [PATCH v3 06/11] fdc: do not call revalidate on eject

2015-12-16 Thread John Snow
Currently, fd_revalidate is called in two different places, with two different expectations of behavior: (1) On initialization, as a routine to help pick the drive type and initial geometries as a side-effect of the pick_geometry routine (2) On insert/eject, which either sets the geometries t