Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-24 Thread Max Reitz
On 24.02.2016 10:28, Markus Armbruster wrote: > Max Reitz writes: > >> On 23.02.2016 10:48, Markus Armbruster wrote: [...] >>> Can you explain the *actual* difference between blk_backends and >>> monitor_block_backends? "Actual" in the sense of difference in contents >>>

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-24 Thread Kevin Wolf
Am 24.02.2016 um 10:28 hat Markus Armbruster geschrieben: > Max Reitz writes: > > > On 23.02.2016 10:48, Markus Armbruster wrote: > >> Max Reitz writes: > >> > >>> On 22.02.2016 09:24, Markus Armbruster wrote: > Max Reitz writes: >

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-24 Thread Markus Armbruster
Max Reitz writes: > On 23.02.2016 10:48, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 22.02.2016 09:24, Markus Armbruster wrote: Max Reitz writes: > On 17.02.2016 17:20, Kevin Wolf wrote: >> Am 17.02.2016 um

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-23 Thread Kevin Wolf
Am 23.02.2016 um 14:52 hat Max Reitz geschrieben: > On 23.02.2016 10:48, Markus Armbruster wrote: > > Max Reitz writes: > > > >> On 22.02.2016 09:24, Markus Armbruster wrote: > >>> Max Reitz writes: > >>> > On 17.02.2016 17:20, Kevin Wolf wrote: >

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-23 Thread Max Reitz
On 23.02.2016 10:48, Markus Armbruster wrote: > Max Reitz writes: > >> On 22.02.2016 09:24, Markus Armbruster wrote: >>> Max Reitz writes: >>> On 17.02.2016 17:20, Kevin Wolf wrote: > Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: >> On

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-23 Thread Markus Armbruster
Max Reitz writes: > On 22.02.2016 09:24, Markus Armbruster wrote: >> Max Reitz writes: >> >>> On 17.02.2016 17:20, Kevin Wolf wrote: Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: > On 17.02.2016 11:53, Kevin Wolf wrote: >> Am 16.02.2016 um

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-22 Thread Max Reitz
On 22.02.2016 09:24, Markus Armbruster wrote: > Max Reitz writes: > >> On 17.02.2016 17:20, Kevin Wolf wrote: >>> Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: On 17.02.2016 11:53, Kevin Wolf wrote: > Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: >> The

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-22 Thread Markus Armbruster
Max Reitz writes: > On 17.02.2016 17:20, Kevin Wolf wrote: >> Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: >>> On 17.02.2016 11:53, Kevin Wolf wrote: Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: > The monitor does hold references to some BlockBackends so it

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-20 Thread Max Reitz
On 20.02.2016 14:34, Max Reitz wrote: > On 17.02.2016 17:20, Kevin Wolf wrote: >> Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: >>> On 17.02.2016 11:53, Kevin Wolf wrote: Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: > The monitor does hold references to some BlockBackends so it

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-20 Thread Max Reitz
On 17.02.2016 17:20, Kevin Wolf wrote: > Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: >> On 17.02.2016 11:53, Kevin Wolf wrote: >>> Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: The monitor does hold references to some BlockBackends so it should have >>> >>> s/does hold/holds/? >> >>

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-17 Thread Kevin Wolf
Am 17.02.2016 um 16:41 hat Max Reitz geschrieben: > On 17.02.2016 11:53, Kevin Wolf wrote: > > Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: > >> The monitor does hold references to some BlockBackends so it should have > > > > s/does hold/holds/? > > It was intentional, so I'd keep it unless

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-17 Thread Max Reitz
On 17.02.2016 11:53, Kevin Wolf wrote: > Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: >> The monitor does hold references to some BlockBackends so it should have > > s/does hold/holds/? It was intentional, so I'd keep it unless you drop the question mark. >> a list of those BBs;

Re: [Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-17 Thread Kevin Wolf
Am 16.02.2016 um 19:08 hat Max Reitz geschrieben: > The monitor does hold references to some BlockBackends so it should have s/does hold/holds/? > a list of those BBs; blk_backends is a different list, as it contains > references to all BBs (after a follow-up patch, that is), and that > should

[Qemu-devel] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends

2016-02-16 Thread Max Reitz
The monitor does hold references to some BlockBackends so it should have a list of those BBs; blk_backends is a different list, as it contains references to all BBs (after a follow-up patch, that is), and that should not be changed because we do need such a list. monitor_remove_blk() is