Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-24 Thread Alberto Garcia
On Mon 24 Sep 2018 03:43:10 PM CEST, Max Reitz wrote: > On 19.09.18 11:18, Alberto Garcia wrote: >> On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: >>> 'discard' is one of the basic BlockdevOptions available for all >>> drivers, but it's not handled by bdrv_reopen_prepare() so any attem

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-24 Thread Max Reitz
On 19.09.18 11:18, Alberto Garcia wrote: > On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: >> 'discard' is one of the basic BlockdevOptions available for all >> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt >> to change it results in an error: >> >>(qemu) qem

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-19 Thread Alberto Garcia
On Thu 06 Sep 2018 11:37:08 AM CEST, Alberto Garcia wrote: > 'discard' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in an error: > >(qemu) qemu-io virtio0 "reopen -o discard=on" >Cannot

Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-13 Thread Max Reitz
On 06.09.18 11:37, Alberto Garcia wrote: > 'discard' is one of the basic BlockdevOptions available for all > drivers, but it's not handled by bdrv_reopen_prepare() so any attempt > to change it results in an error: > >(qemu) qemu-io virtio0 "reopen -o discard=on" >Cannot change the option

[Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen

2018-09-06 Thread Alberto Garcia
'discard' is one of the basic BlockdevOptions available for all drivers, but it's not handled by bdrv_reopen_prepare() so any attempt to change it results in an error: (qemu) qemu-io virtio0 "reopen -o discard=on" Cannot change the option 'discard' Since there's no reason why we shouldn't a