Re: [Qemu-devel] [PATCH v3 09/22] target/arm: Add pre-EL change hooks

2018-04-12 Thread Peter Maydell
On 12 April 2018 at 18:01, Aaron Lindsay wrote: > On Apr 12 17:49, Peter Maydell wrote: >> Do we make the guarantee that if we call the pre-change hook >> then we will definitely subsequently call the post-change hook? >> (ie does the PMU hook rely on that?) > > Yes, the

Re: [Qemu-devel] [PATCH v3 09/22] target/arm: Add pre-EL change hooks

2018-04-12 Thread Aaron Lindsay
On Apr 12 17:49, Peter Maydell wrote: > On 16 March 2018 at 20:31, Aaron Lindsay wrote: > > Because the design of the PMU requires that the counter values be > > converted between their delta and guest-visible forms for mode > > filtering, an additional hook which occurs

Re: [Qemu-devel] [PATCH v3 09/22] target/arm: Add pre-EL change hooks

2018-04-12 Thread Peter Maydell
On 16 March 2018 at 20:31, Aaron Lindsay wrote: > Because the design of the PMU requires that the counter values be > converted between their delta and guest-visible forms for mode > filtering, an additional hook which occurs before the EL is changed is > necessary. > >

[Qemu-devel] [PATCH v3 09/22] target/arm: Add pre-EL change hooks

2018-03-16 Thread Aaron Lindsay
Because the design of the PMU requires that the counter values be converted between their delta and guest-visible forms for mode filtering, an additional hook which occurs before the EL is changed is necessary. Signed-off-by: Aaron Lindsay --- target/arm/cpu.c |