Re: [Qemu-devel] [PATCH v3 09/26] HACK: vhost-user-backend: allow to specify binary to execute

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 08:19:03AM +0200, Gerd Hoffmann wrote: > On Mon, Jun 18, 2018 at 06:17:12PM +0200, Marc-André Lureau wrote: > > An executable with its arguments may be given as 'cmd' property, ex: > > -object vhost-user-backend,id=vui,cmd="./vhost-user-input > > /dev/input..". The executabl

Re: [Qemu-devel] [PATCH v3 09/26] HACK: vhost-user-backend: allow to specify binary to execute

2018-06-18 Thread Gerd Hoffmann
On Mon, Jun 18, 2018 at 06:17:12PM +0200, Marc-André Lureau wrote: > An executable with its arguments may be given as 'cmd' property, ex: > -object vhost-user-backend,id=vui,cmd="./vhost-user-input > /dev/input..". The executable is then spawn and, by convention, the > vhost-user socket is passed a

[Qemu-devel] [PATCH v3 09/26] HACK: vhost-user-backend: allow to specify binary to execute

2018-06-18 Thread Marc-André Lureau
An executable with its arguments may be given as 'cmd' property, ex: -object vhost-user-backend,id=vui,cmd="./vhost-user-input /dev/input..". The executable is then spawn and, by convention, the vhost-user socket is passed as fd=3. It may be considered a security breach to allow creating processes