[Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-01 Thread Kewei Yu
When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. Signed-off-by: Kewei Yu --- v2: Consolidate VNC macro's #ifdef'ery to one central point (tests/libqtest.c). v3: Fix the spelling and terminology error: "s/di

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
Ping. Faithfully yours Kewei Yu 2014/1/2 Kewei Yu > When we disable vnc from "./configure", QEMU can't use the vnc option. > So qtest can't use the "vnc -none ", otherwise "make check" fails. > > Signed-off-by: Kewei Yu > --- > v2: Consolidate VNC macro's #ifdef'ery to one central point > (t

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Peter Crosthwaite
Hi Kewei, On Mon, Jan 6, 2014 at 12:22 PM, Kewei Yu wrote: > Ping. > Paolo's latest query on the other thread is still an open question. Does simply substituting "-display none" for "-vnc none" resolve the problem? If not why not? Regards, Peter > Faithfully yours > Kewei Yu > > > 2014/1/2 Kew

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Andreas Färber
Am 06.01.2014 04:13, schrieb Peter Crosthwaite: > Hi Kewei, > > On Mon, Jan 6, 2014 at 12:22 PM, Kewei Yu wrote: >> Ping. >> > > Paolo's latest query on the other thread is still an open question. > Does simply substituting "-display none" for "-vnc none" resolve the > problem? If not why not?

Re: [Qemu-devel] [PATCH v3 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-05 Thread Kewei Yu
OK, I'm viewing the code about the two parameters. Thanks for your reply. Faithfully yours Kewei Yu 2014/1/6 Peter Crosthwaite > Hi Kewei, > > On Mon, Jan 6, 2014 at 12:22 PM, Kewei Yu wrote: > > Ping. > > > > Paolo's latest query on the other thread is still an open question. > Does simply s