Re: [Qemu-devel] [PATCH v3 1/2] qapi: open files in binary mode and use explicit decoding/encoding in common.py

2018-06-18 Thread Eduardo Habkost
On Mon, Jun 18, 2018 at 06:17:04PM -0300, Eduardo Habkost wrote: > On Mon, Jun 18, 2018 at 07:54:26PM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > On Mon, Jun 18, 2018 at 07:25:14AM +0200, Markus Armbruster wrote: > > >> Matthias Maier writes: > > >> > > >> > This is a

Re: [Qemu-devel] [PATCH v3 1/2] qapi: open files in binary mode and use explicit decoding/encoding in common.py

2018-06-18 Thread Eduardo Habkost
On Mon, Jun 18, 2018 at 07:54:26PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Jun 18, 2018 at 07:25:14AM +0200, Markus Armbruster wrote: > >> Matthias Maier writes: > >> > >> > This is a different approach to fix the locale dependent encode/decode > >> > problem in

Re: [Qemu-devel] [PATCH v3 1/2] qapi: open files in binary mode and use explicit decoding/encoding in common.py

2018-06-18 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Jun 18, 2018 at 07:25:14AM +0200, Markus Armbruster wrote: >> Matthias Maier writes: >> >> > This is a different approach to fix the locale dependent encode/decode >> > problem in common.py utilizing the binary read/write mode [1,2], and (if >> > a python 3 int

Re: [Qemu-devel] [PATCH v3 1/2] qapi: open files in binary mode and use explicit decoding/encoding in common.py

2018-06-18 Thread Eduardo Habkost
On Mon, Jun 18, 2018 at 07:25:14AM +0200, Markus Armbruster wrote: > Matthias Maier writes: > > > This is a different approach to fix the locale dependent encode/decode > > problem in common.py utilizing the binary read/write mode [1,2], and (if > > a python 3 interpreter is used) with explicit d

Re: [Qemu-devel] [PATCH v3 1/2] qapi: open files in binary mode and use explicit decoding/encoding in common.py

2018-06-18 Thread Matthias Maier
On Mon, Jun 18, 2018, at 00:25 CDT, Markus Armbruster wrote: > Matthias Maier writes: > >> This is a different approach to fix the locale dependent encode/decode >> problem in common.py utilizing the binary read/write mode [1,2], and (if >> a python 3 interpreter is used) with explicit decode/

Re: [Qemu-devel] [PATCH v3 1/2] qapi: open files in binary mode and use explicit decoding/encoding in common.py

2018-06-17 Thread Markus Armbruster
Matthias Maier writes: > This is a different approach to fix the locale dependent encode/decode > problem in common.py utilizing the binary read/write mode [1,2], and (if > a python 3 interpreter is used) with explicit decode/encode arguments > [3]. Why can't we simply pass encoding='utf-8' to o

[Qemu-devel] [PATCH v3 1/2] qapi: open files in binary mode and use explicit decoding/encoding in common.py

2018-06-15 Thread Matthias Maier
This is a different approach to fix the locale dependent encode/decode problem in common.py utilizing the binary read/write mode [1,2], and (if a python 3 interpreter is used) with explicit decode/encode arguments [3]. This approach is preferred over the fix in commit d4e5ec877ca because it is (a)