Re: [Qemu-devel] [PATCH v3 1/2] realview: break out the i2c controller code

2012-04-11 Thread Paul Brook
> +++ b/hw/versatile_i2c.c > @@ -0,0 +1,102 @@ > +/* > + * Versatile I2C controller I'd go for "ARM Versatile I2C controller". I wish companies wouldn't pick generic terms as product names :-( That's not your fault though! > + * > + * Copyright (C) 2012 Oskar Andero AFAICS You've copy/pasted

Re: [Qemu-devel] [PATCH v3 1/2] realview: break out the i2c controller code

2012-04-11 Thread Peter Maydell
On 11 April 2012 14:50, Paul Brook wrote: >> +++ b/hw/versatile_i2c.c >> @@ -0,0 +1,102 @@ >> +/* >> + * Versatile I2C controller > > I'd go for "ARM Versatile I2C controller". Strictly speaking, the ARM devboard manuals don't actually call this an I2C controller, it's a "custom two-wire serial b

[Qemu-devel] [PATCH v3 1/2] realview: break out the i2c controller code

2012-04-10 Thread Oskar Andero
The versatile i2c controller implementation was separated to its own file called versatile_i2c.c. This is done as a preparation for adding i2c support to the versatilepb board. Signed-off-by: Oskar Andero --- Makefile.target|1 + hw/realview.c | 83 +---