Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-23 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 03:43:02PM +0200, Thibaut Collet wrote: Some vhost client/backend are able to support live migration. To provide this service the following features must be added: 1. GARP from guest after live migration: the VIRTIO_NET_F_GUEST_ANNOUNCE capability is added to

[Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Thibaut Collet
Some vhost client/backend are able to support live migration. To provide this service the following features must be added: 1. GARP from guest after live migration: the VIRTIO_NET_F_GUEST_ANNOUNCE capability is added to vhost-net when netdev backend is vhost-user to let virtio-net NIC

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 03:43:02PM +0200, Thibaut Collet wrote: Some vhost client/backend are able to support live migration. To provide this service the following features must be added: 1. GARP from guest after live migration: the VIRTIO_NET_F_GUEST_ANNOUNCE capability is added to

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Thibaut Collet
I am not sure to understand your comments. Could you confirm that the useless warning is: +fprintf(stderr, +Warning: Guest with no VIRTIO_NET_F_GUEST_ANNOUNCE support. RARP must be sent by vhost-user backend\n); Can you move this out to vhost-user? It's not a generic

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Michael S. Tsirkin
On Wed, Jun 10, 2015 at 04:22:10PM +0200, Thibaut Collet wrote: I am not sure to understand your comments. Could you confirm that the useless warning is: +        fprintf(stderr, +                Warning: Guest with no VIRTIO_NET_F_GUEST_ANNOUNCE support. RARP must be sent by vhost-user

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Stefan Hajnoczi
On Wed, Jun 10, 2015 at 03:52:43PM +0200, Michael S. Tsirkin wrote: +void vhost_net_inject_rarp(struct vhost_net *net, const uint8_t *buf, size_t size) +{ +if ((net-dev.acked_features (1 VIRTIO_NET_F_GUEST_ANNOUNCE)) == 0) { +fprintf(stderr, +Warning:

Re: [Qemu-devel] [PATCH v3 1/2] vhost user: add support of live migration

2015-06-10 Thread Thibaut Collet
vhost_net_inject_rarp is vhost-user specific. For this function test on VIRTIO_NET_F_GUEST_ANNOUNCE bit is important to take a decision and call a new vhost ioctl (see next patch) if the guest does not support this feature and allow the vhost client/backend send the RARP packet. Use of the