Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-07 Thread Huang, Kai
On 6/8/2016 6:46 AM, Alex Williamson wrote: On Tue, 7 Jun 2016 17:21:06 +1200 "Huang, Kai" wrote: On 6/7/2016 3:58 PM, Alex Williamson wrote: On Tue, 7 Jun 2016 11:20:32 +0800 Peter Xu wrote: On Mon, Jun 06, 2016 at 11:02:11AM -0600, Alex

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-07 Thread Alex Williamson
On Tue, 7 Jun 2016 17:21:06 +1200 "Huang, Kai" wrote: > On 6/7/2016 3:58 PM, Alex Williamson wrote: > > On Tue, 7 Jun 2016 11:20:32 +0800 > > Peter Xu wrote: > > > >> On Mon, Jun 06, 2016 at 11:02:11AM -0600, Alex Williamson wrote: > >>> On Mon,

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Huang, Kai
On 6/7/2016 3:58 PM, Alex Williamson wrote: On Tue, 7 Jun 2016 11:20:32 +0800 Peter Xu wrote: On Mon, Jun 06, 2016 at 11:02:11AM -0600, Alex Williamson wrote: On Mon, 6 Jun 2016 21:43:17 +0800 Peter Xu wrote: On Mon, Jun 06, 2016 at 07:11:41AM

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Peter Xu
On Mon, Jun 06, 2016 at 09:58:09PM -0600, Alex Williamson wrote: > On Tue, 7 Jun 2016 11:20:32 +0800 > Peter Xu wrote: [...] > > Only if cap_caching_mode() is set (which is bit 7, the CM bit), we > > will send these invalidations. What I meant is that, we should allow > > user

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Alex Williamson
On Tue, 7 Jun 2016 11:20:32 +0800 Peter Xu wrote: > On Mon, Jun 06, 2016 at 11:02:11AM -0600, Alex Williamson wrote: > > On Mon, 6 Jun 2016 21:43:17 +0800 > > Peter Xu wrote: > > > > > On Mon, Jun 06, 2016 at 07:11:41AM -0600, Alex Williamson wrote: >

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Peter Xu
On Mon, Jun 06, 2016 at 11:02:11AM -0600, Alex Williamson wrote: > On Mon, 6 Jun 2016 21:43:17 +0800 > Peter Xu wrote: > > > On Mon, Jun 06, 2016 at 07:11:41AM -0600, Alex Williamson wrote: > > > On Mon, 6 Jun 2016 13:04:07 +0800 > > > Peter Xu wrote: > >

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Alex Williamson
On Mon, 6 Jun 2016 21:43:17 +0800 Peter Xu wrote: > On Mon, Jun 06, 2016 at 07:11:41AM -0600, Alex Williamson wrote: > > On Mon, 6 Jun 2016 13:04:07 +0800 > > Peter Xu wrote: > [...] > > > Besides the reason that there might have guests that do not

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Peter Xu
On Mon, Jun 06, 2016 at 07:11:41AM -0600, Alex Williamson wrote: > On Mon, 6 Jun 2016 13:04:07 +0800 > Peter Xu wrote: [...] > > Besides the reason that there might have guests that do not support > > CM=1, will there be performance considerations? When user's > > configuration

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-06 Thread Alex Williamson
On Mon, 6 Jun 2016 13:04:07 +0800 Peter Xu wrote: > On Thu, Jun 02, 2016 at 03:14:36PM +0200, Jan Kiszka wrote: > > On 2016-06-02 15:00, Alex Williamson wrote: > > > On Thu, 2 Jun 2016 16:44:39 +0800 > > > Peter Xu wrote: > [...] > > >> There should be

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-05 Thread Peter Xu
On Thu, Jun 02, 2016 at 03:14:36PM +0200, Jan Kiszka wrote: > On 2016-06-02 15:00, Alex Williamson wrote: > > On Thu, 2 Jun 2016 16:44:39 +0800 > > Peter Xu wrote: [...] > >> There should be more than one way to make it optional. Which is > >> better? What I can think of: > >>

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-02 Thread Michael S. Tsirkin
On Thu, Jun 02, 2016 at 03:14:36PM +0200, Jan Kiszka wrote: > On 2016-06-02 15:00, Alex Williamson wrote: > > On Thu, 2 Jun 2016 16:44:39 +0800 > > Peter Xu wrote: > > > >> On Sat, May 21, 2016 at 06:42:03PM +0200, Jan Kiszka wrote: > >>> On 2016-05-21 18:19, Aviv B.D wrote:

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-02 Thread Jan Kiszka
On 2016-06-02 15:14, Jan Kiszka wrote: > On 2016-06-02 15:00, Alex Williamson wrote: >> On Thu, 2 Jun 2016 16:44:39 +0800 >> Peter Xu wrote: >> >>> On Sat, May 21, 2016 at 06:42:03PM +0200, Jan Kiszka wrote: On 2016-05-21 18:19, Aviv B.D wrote: > From: "Aviv

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-02 Thread Jan Kiszka
On 2016-06-02 15:00, Alex Williamson wrote: > On Thu, 2 Jun 2016 16:44:39 +0800 > Peter Xu wrote: > >> On Sat, May 21, 2016 at 06:42:03PM +0200, Jan Kiszka wrote: >>> On 2016-05-21 18:19, Aviv B.D wrote: From: "Aviv Ben-David" This flag

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-02 Thread Alex Williamson
On Thu, 2 Jun 2016 16:44:39 +0800 Peter Xu wrote: > On Sat, May 21, 2016 at 06:42:03PM +0200, Jan Kiszka wrote: > > On 2016-05-21 18:19, Aviv B.D wrote: > > > From: "Aviv Ben-David" > > > > > > This flag tells the guest to invalidate tlb cache also after

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-06-02 Thread Peter Xu
On Sat, May 21, 2016 at 06:42:03PM +0200, Jan Kiszka wrote: > On 2016-05-21 18:19, Aviv B.D wrote: > > From: "Aviv Ben-David" > > > > This flag tells the guest to invalidate tlb cache also after unmap > > operations. > > > > Signed-off-by: Aviv Ben-David

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-05-28 Thread Kiszka, Jan
(CT RDA ITP SES-DE) [jan.kis...@siemens.com]; Jason Wang [jasow...@redhat.com]; qemu-devel@nongnu.org [qemu-devel@nongnu.org] CC: Alex Williamson [alex.william...@redhat.com]; Peter Xu [pet...@redhat.com]; Michael S. Tsirkin [m...@redhat.com] Subject: Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-05-28 Thread Aviv B.D.
What is the best way to add this configuration option? Aviv. On Tue, May 24, 2016 at 12:25 PM Jan Kiszka wrote: > On 2016-05-24 10:14, Jason Wang wrote: > > On 2016年05月22日 00:19, Aviv B.D wrote: > >> From: "Aviv Ben-David" > >> > >> This flag tells

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-05-24 Thread Jan Kiszka
On 2016-05-24 10:14, Jason Wang wrote: > On 2016年05月22日 00:19, Aviv B.D wrote: >> From: "Aviv Ben-David" >> >> This flag tells the guest to invalidate tlb cache also after unmap >> operations. >> >> Signed-off-by: Aviv Ben-David >> --- > > Is this a guest

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-05-24 Thread Jason Wang
On 2016年05月22日 00:19, Aviv B.D wrote: From: "Aviv Ben-David" This flag tells the guest to invalidate tlb cache also after unmap operations. Signed-off-by: Aviv Ben-David --- Is this a guest visible behavior? If yes, shouldn't we cache translation

Re: [Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-05-21 Thread Jan Kiszka
On 2016-05-21 18:19, Aviv B.D wrote: > From: "Aviv Ben-David" > > This flag tells the guest to invalidate tlb cache also after unmap operations. > > Signed-off-by: Aviv Ben-David > --- > hw/i386/intel_iommu.c | 3 ++- >

[Qemu-devel] [PATCH v3 1/3] IOMMU: add VTD_CAP_CM to vIOMMU capability exposed to guest

2016-05-21 Thread Aviv B.D
From: "Aviv Ben-David" This flag tells the guest to invalidate tlb cache also after unmap operations. Signed-off-by: Aviv Ben-David --- hw/i386/intel_iommu.c | 3 ++- hw/i386/intel_iommu_internal.h | 1 + 2 files changed, 3 insertions(+), 1