On 11/28/2017 02:05 PM, Eric Blake wrote:
Better yet, please fix the PFLASH_DEBUG code to avoid bitrot in the
first place, by rewriting the bad pattern:
into the good pattern:
#ifdef PFLASH_DEBUG
# define PFLASH_PRINT 1
#else
# define PFLASH_PRINT 0
#endif
#define DPRINTF(fmt, ...) \
do {
On 11/28/2017 01:47 PM, Michael Nawrocki wrote:
I suspect you'll find that the change of type for 'ret' here
and the 'value' argument to pflash_write() will break compilation
with PFLASH_DEBUG defined, because the type won't match the DPRINTF
format strings any more.
You could either fix up the
On 11/23/2017 06:27 AM, Peter Maydell wrote:
On 23 November 2017 at 11:26, Peter Maydell wrote:
On 13 November 2017 at 16:14, Mike Nawrocki
wrote:
Signed-off-by: Mike Nawrocki
---
hw/block/pflash_cfi02.c | 97 +
1 file changed, 18 insertions
On 23 November 2017 at 11:26, Peter Maydell wrote:
> On 13 November 2017 at 16:14, Mike Nawrocki
> wrote:
>> Signed-off-by: Mike Nawrocki
>> ---
>> hw/block/pflash_cfi02.c | 97
>> +
>> 1 file changed, 18 insertions(+), 79 deletions(-)
>>
>> diff
On 13 November 2017 at 16:14, Mike Nawrocki
wrote:
> Signed-off-by: Mike Nawrocki
> ---
> hw/block/pflash_cfi02.c | 97
> +
> 1 file changed, 18 insertions(+), 79 deletions(-)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> in
Signed-off-by: Mike Nawrocki
---
hw/block/pflash_cfi02.c | 97 +
1 file changed, 18 insertions(+), 79 deletions(-)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index c81ddd3a99..a81df913f6 100644
--- a/hw/block/pflash_cfi02.c
+++
