Re: [Qemu-devel] [PATCH v3 1/3] target/arm: Introduce arm_hcr_el2_eff

2018-12-10 Thread Richard Henderson
On 12/10/18 8:22 AM, Peter Maydell wrote: > This section that clears VI/VF/VSE is new, and I'm not sure it's right. > The spec says that the virtual IRQ interrupt is enabled only if {TGE,IMO} > is {0,1}, but the meaning of the bit is "pending", and an interrupt > can be pending without being

Re: [Qemu-devel] [PATCH v3 1/3] target/arm: Introduce arm_hcr_el2_eff

2018-12-10 Thread Peter Maydell
On Thu, 6 Dec 2018 at 17:55, Richard Henderson wrote: > > Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine > that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into > account, as documented for the plethora of bits in HCR_EL2. > > Signed-off-by: Richard Henderson > > v3:

[Qemu-devel] [PATCH v3 1/3] target/arm: Introduce arm_hcr_el2_eff

2018-12-06 Thread Richard Henderson
Replace arm_hcr_el2_{fmo,imo,amo} with a more general routine that also takes SCR_EL3.NS (aka arm_is_secure_below_el3) into account, as documented for the plethora of bits in HCR_EL2. Signed-off-by: Richard Henderson v3: Fix set of bits affected by just TGE. Reorder the bits to