[Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2019-03-09 Thread Philippe Mathieu-Daudé
Add a function to read the full content of file on the host, and add a new 'file' name item to the fw_cfg device. Signed-off-by: Philippe Mathieu-Daudé --- v2: s/ptr/data, corrected documentation (Laszlo) v3: inverted the if() logic --- hw/nvram/fw_cfg.c | 21 + inclu

Re: [Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2019-03-11 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Add a function to read the full content of file on the host, and add > a new 'file' name item to the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: s/ptr/data, corrected documentation (Laszlo) > v3: inverted the if() logic > --- > hw/nvram/

Re: [Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2019-03-13 Thread Laszlo Ersek
On 03/13/19 10:29, Laszlo Ersek wrote: > (it's easiest if I follow up under Markus's review) > > On 03/11/19 08:15, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Add a function to read the full content of file on the host, and add >>> a new 'file' name item to the fw_cfg devic

Re: [Qemu-devel] [PATCH v3 1/4] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host()

2019-03-13 Thread Laszlo Ersek
(it's easiest if I follow up under Markus's review) On 03/11/19 08:15, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Add a function to read the full content of file on the host, and add >> a new 'file' name item to the fw_cfg device. >> >> Signed-off-by: Philippe Mathieu-Daudé