Re: [Qemu-devel] [PATCH v3 1/5] pnv_core: drop reference on ICPState object during CPU realization

2017-06-07 Thread David Gibson
On Wed, Jun 07, 2017 at 07:49:14PM +0200, Cédric Le Goater wrote: > On 06/07/2017 07:16 PM, Greg Kurz wrote: > > Similarly to what was done to spapr with commit 249127d0dfeb, this patch > > ensures that we don't keep an extra reference on the ICPState object. Also > > since the object was just

Re: [Qemu-devel] [PATCH v3 1/5] pnv_core: drop reference on ICPState object during CPU realization

2017-06-07 Thread Cédric Le Goater
On 06/07/2017 07:16 PM, Greg Kurz wrote: > Similarly to what was done to spapr with commit 249127d0dfeb, this patch > ensures that we don't keep an extra reference on the ICPState object. Also > since the object was just created and not reparented yet, the call to > object_property_add_child()

[Qemu-devel] [PATCH v3 1/5] pnv_core: drop reference on ICPState object during CPU realization

2017-06-07 Thread Greg Kurz
Similarly to what was done to spapr with commit 249127d0dfeb, this patch ensures that we don't keep an extra reference on the ICPState object. Also since the object was just created and not reparented yet, the call to object_property_add_child() should never fail: let's pass _abort to make this